refactor(autoware_interpolation): prefix package and namespace with autoware #8088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:documentation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
esteve
added
the
tag:run-build-and-test-differential
esteve
force-pushed
the
prefix-interpolation
branch
from
74fe54d
to
b8ec936
Compare
esteve
force-pushed
the
prefix-interpolation
branch
from
b8ec936
to
eff4efe
Compare
esteve
force-pushed
the
prefix-interpolation
branch
4 times, most recently
from
0d0a5c5
to
365cd33
Compare
esteve
requested review from
mkuri,
zusizusi,
taikitanaka3,
TakaHoribe,
soblin,
maxime-clem,
tkimura4,
zulfaqar-azmi-t4,
rej55,
isamu-takagi,
shmpwk and
kosuke55
as code owners
|
merged #8630 to debug |
kosuke55
force-pushed
the
prefix-interpolation
branch
from
c895278
to
980d6c5
Compare
|
I merged #8631, it probably pass the test, |
|
Because I rebased with the latest autoware to pass the test, there are other areas that need to be replaced. Could you please fix this? 🙏
|
|
required tests pass!!
|
esteve
force-pushed
the
prefix-interpolation
branch
from
df59929
to
e321949
Compare
|
@kosuke55 thanks for the fixes 🙇♂️ I've rebased this PR on top of |
esteve
force-pushed
the
prefix-interpolation
branch
2 times, most recently
from
7901971
to
300fa08
Compare
|
@mitsudome-r @xmfcx I've fixed the conflicts again, could you approve this PR when you can? Thanks |
…utoware Signed-off-by: Esteve Fernandez <[email protected]>
Signed-off-by: kosuke55 <[email protected]>
* fix(interpolation): fix bug of interpolation Signed-off-by: Y.Hisaki <[email protected]> * add const Signed-off-by: Y.Hisaki <[email protected]> * auto -> int64_t Signed-off-by: Y.Hisaki <[email protected]> * add const Signed-off-by: Y.Hisaki <[email protected]> * add const Signed-off-by: Y.Hisaki <[email protected]> * add const Signed-off-by: Y.Hisaki <[email protected]> --------- Signed-off-by: Y.Hisaki <[email protected]>
xmfcx
force-pushed
the
prefix-interpolation
branch
from
a71a85c
to
4996cf7
Compare
|
I see that
So to keep @esteve 's commits intact:
Now it's all on the main branch again, rebased. |
|
@yhisaki could you check if your changes are applied correctly? |
Signed-off-by: M. Fatih Cırıt <[email protected]>
7 tasks
|
Tested the latest changes using AWSIM Labs to test it end to end. And it works without problems.
|
|
@yhisaki I've merged this since it has been up for a long while and it becomes harder as more time passes since it's a large refactor. Please check and confirm if the changes from:
|
|
I have confirmation that my PR is properly in place. |
46 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
prefix package and namespace with autoware
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.